diff --git a/tools/tiffcrop.c b/tools/tiffcrop.c index 9f33be49b538055cf025375d34f0a0887631ce84..acd175348c4ba2b59d0c8dc86c9d3f00d3e6eb4f 100644 --- a/tools/tiffcrop.c +++ b/tools/tiffcrop.c @@ -271,7 +271,6 @@ struct region { uint32 width; /* width in pixels */ uint32 length; /* length in pixels */ uint32 buffsize; /* size of buffer needed to hold the cropped region */ - unsigned char *buffptr; /* address of start of the region */ }; /* Cropping parameters from command line and image data @@ -526,7 +525,7 @@ static int rotateContigSamples24bits(uint16, uint16, uint16, uint32, static int rotateContigSamples32bits(uint16, uint16, uint16, uint32, uint32, uint32, uint8 *, uint8 *); static int rotateImage(uint16, struct image_data *, uint32 *, uint32 *, - unsigned char **); + unsigned char **, size_t *, int); static int mirrorImage(uint16, uint16, uint16, uint32, uint32, unsigned char *); static int invertImage(uint16, uint16, uint16, uint32, uint32, @@ -5079,7 +5078,6 @@ initCropMasks (struct crop_mask *cps) cps->regionlist[i].width = 0; cps->regionlist[i].length = 0; cps->regionlist[i].buffsize = 0; - cps->regionlist[i].buffptr = NULL; cps->zonelist[i].position = 0; cps->zonelist[i].total = 0; } @@ -6314,7 +6312,12 @@ static int correct_orientation(struct image_data *image, unsigned char **work_b return (-1); } - if (rotateImage(rotation, image, &image->width, &image->length, work_buff_ptr)) + /* Dummy variable in order not to switch two times the + * image->width,->length within rotateImage(), + * but switch xres, yres there. */ + uint32_t width = image->width; + uint32_t length = image->length; + if (rotateImage(rotation, image, &width, &length, work_buff_ptr, NULL,TRUE)) { TIFFError ("correct_orientation", "Unable to rotate image"); return (-1); @@ -6382,7 +6385,6 @@ extractCompositeRegions(struct image_data *image, struct crop_mask *crop, /* These should not be needed for composite images */ crop->regionlist[i].width = crop_width; crop->regionlist[i].length = crop_length; - crop->regionlist[i].buffptr = crop_buff; src_rowsize = ((img_width * bps * spp) + 7) / 8; dst_rowsize = (((crop_width * bps * count) + 7) / 8); @@ -6619,7 +6621,6 @@ extractSeparateRegion(struct image_data *image, struct crop_mask *crop, crop->regionlist[region].width = crop_width; crop->regionlist[region].length = crop_length; - crop->regionlist[region].buffptr = crop_buff; src = read_buff; dst = crop_buff; @@ -7497,7 +7498,7 @@ processCropSelections(struct image_data *image, struct crop_mask *crop, if (crop->crop_mode & CROP_ROTATE) /* rotate should be last as it can reallocate the buffer */ { if (rotateImage(crop->rotation, image, &crop->combined_width, - &crop->combined_length, &crop_buff)) + &crop->combined_length, &crop_buff, &rot_buf_size, FALSE)) { TIFFError("processCropSelections", "Failed to rotate composite regions by %d degrees", crop->rotation); @@ -7602,8 +7603,10 @@ processCropSelections(struct image_data *image, struct crop_mask *crop, if (crop->crop_mode & CROP_ROTATE) /* rotate should be last as it can reallocate the buffer */ { - if (rotateImage(crop->rotation, image, &crop->regionlist[i].width, - &crop->regionlist[i].length, &crop_buff)) + if (rotateImage(crop->rotation, image, + &crop->regionlist[i].width, + &crop->regionlist[i].length, &crop_buff, + &rot_buf_size, FALSE)) { TIFFError("processCropSelections", "Failed to rotate crop region by %d degrees", crop->rotation); @@ -7735,7 +7738,7 @@ createCroppedImage(struct image_data *image, struct crop_mask *crop, if (crop->crop_mode & CROP_ROTATE) /* rotate should be last as it can reallocate the buffer */ { if (rotateImage(crop->rotation, image, &crop->combined_width, - &crop->combined_length, crop_buff_ptr)) + &crop->combined_length, crop_buff_ptr, NULL, TRUE)) { TIFFError("createCroppedImage", "Failed to rotate image or cropped selection by %d degrees", crop->rotation); @@ -8398,7 +8401,8 @@ rotateContigSamples32bits(uint16 rotation, uint16 spp, uint16 bps, uint32 width, /* Rotate an image by a multiple of 90 degrees clockwise */ static int rotateImage(uint16 rotation, struct image_data *image, uint32 *img_width, - uint32 *img_length, unsigned char **ibuff_ptr) + uint32 *img_length, unsigned char **ibuff_ptr, size_t *rot_buf_size, + int rot_image_params) { int shift_width; uint32 bytes_per_pixel, bytes_per_sample; @@ -8589,11 +8593,15 @@ rotateImage(uint16 rotation, struct image_data *image, uint32 *img_width, *img_width = length; *img_length = width; - image->width = length; - image->length = width; - res_temp = image->xres; - image->xres = image->yres; - image->yres = res_temp; + /* Only toggle image parameters if whole input image is rotated. */ + if (rot_image_params) + { + image->width = length; + image->length = width; + res_temp = image->xres; + image->xres = image->yres; + image->yres = res_temp; + } break; case 270: if ((bps % 8) == 0) /* byte aligned data */ @@ -8666,11 +8674,15 @@ rotateImage(uint16 rotation, struct image_data *image, uint32 *img_width, *img_width = length; *img_length = width; - image->width = length; - image->length = width; - res_temp = image->xres; - image->xres = image->yres; - image->yres = res_temp; + /* Only toggle image parameters if whole input image is rotated. */ + if (rot_image_params) + { + image->width = length; + image->length = width; + res_temp = image->xres; + image->xres = image->yres; + image->yres = res_temp; + } break; default: break;